Skip to content

fix(components): element:number reads its object from dataSource.object, as the spec binding declares (objectui#10909) - #10944

Merged
objectstack-fleet[bot] merged 5 commits into
mainfrom
claude/issue-10909-element-number-datasource
Sep 28, 2026
Merged

objectstack-fleet[bot] merged 5 commits into
mainfrom
claude/issue-10909-element-number-datasource

Conversation

@objectstack-fleet

@objectstack-fleet objectstack-fleet Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #10909
Clause-②: yes (widening)

Implemented on branch claude/issue-10909-element-number-datasource by the os-dev run dispatched from the domain:ui seat 2 session session_014mXUNuFomfj24w7s1pZzhN (claim comment 5866532141 on the card).

What changed

  • ElementNumberRenderer (packages/components/src/renderers/basic/elements.tsx) now reads the spec's per-element binding (PageComponentSchema.dataSource) through useElementDataSource, the way its element twin element:record_picker does.
    • The object resolves ONCE as dataSource.object ?? properties.object, and that one value is the fetch guard, the adapter.aggregate / adapter.find target and the useDataInvalidation key. dataSource.object wins when both are set.
    • While a named view is unresolved or unresolvable, there is no object, even beside a flat properties.object.
  • Filter (seat ruling B): with a binding present, properties.filter is AND-combined with the binding's filter and with its view's. The lowering and merge are the ones ElementDataSourceGate uses (toFilterNodeSafely + mergeFilterNodes), so neither filter is dropped. A merge the converter refuses shows the configuration-error panel and aggregates nothing. With no binding, properties.filter reaches the adapter exactly as authored.
  • Registration: element:number is registered through elementDataSourceBlock(...) (from @object-ui/core), so Registry.register injects the one shared dataSource declaration (ELEMENT_DATA_SOURCE_INPUT, binding: 'object').
    • object is no longer required: true.
    • The object input's description states its precedence.
    • The filter input's description is exactly: "Criteria the aggregate is scoped by. When a node-level dataSource binding also supplies a filter (its own, or the saved view its view names), the two are AND-combined: neither is dropped."
  • Pins: new packages/components/src/renderers/basic/__tests__/elementNumber.dataSourceBinding-10909.test.tsx (18 rows). It is registered as the element:number.dataSource member pin in apps/console/src/__tests__/registry-inputs-spec-parity.test.ts, which the parity census requires once the block declares an object-armed input.
  • Docs: content/docs/guide/data-source.md gains the element:number row in the per-element binding table. A paragraph says how the two element:* rows read the binding, and that they differ on filter: record_picker substitutes, element:number AND-combines.
  • Changeset: .changeset/10909-element-number-datasource.md, '@object-ui/components': minor, with Clause-②: yes (widening).

H1: reproduced on main (733fd5a)

The probe used the real SchemaRenderer, the real registry, and an AdapterCtx adapter with aggregate / find spies. The probe file was temporary and not committed.

H1 dataSource-form :: aggregate calls=[] find calls=[] painted="—"
H1 properties-form :: aggregate calls=["contact"] find calls=[] painted="7"

The same probe on this branch:

H1 dataSource-form :: aggregate calls=["contact"] find calls=[] painted="7"
H1 properties-form :: aggregate calls=["contact"] find calls=[] painted="7"

ElementDataSourceSchema members: which ones this renderer reads

member read? how
object yes dataSource.object ?? properties.object. There is no object at all while a named view is unresolved or unresolvable. A binding naming no object (empty or not a string) supplies nothing, and the flat object stands.
view yes Through useElementDataSource: the saved view's filter scopes the aggregate. While the view resolves, the shared loading panel shows and nothing is read. If it cannot be resolved, the shared error panel (element-number-datasource-error) shows and nothing is aggregated.
filter yes properties.filter AND (view filter AND binding filter), lowered and merged as ElementDataSourceGate does. Neither is dropped; a refused merge reports and aggregates nothing. Context tokens are handled by the existing useResolvedFilter on the merged value. There is no record-context binding (objectui#7297 stays on hold), and the filter-shape note (objectui#8945) is untouched.
sort no An aggregate has no ordering. It never reaches aggregate() or find(), and the whole options bag is asserted.
limit no A capped count would be a wrong number. Neither the binding's nor a view's pagination.pageSize reaches aggregate() or the find() fallback.
columns / viewType (view-only composed keys) no A metric has no projection and no view kind.

No member is declared per member. The only declaration is the injected dataSource input (type: 'object', binding: 'object'), whose description lists the binding's five members generically. Which of them this block reads is pinned at the read site.

The registration change: what elementDataSourceBlock changes, exactly

elementDataSourceBlock is a marker. It adds the renderer to a WeakSet and returns it unchanged, so it adds no gate, no loading state and no fetch. The declaration is emitted by withElementDataSourceInput inside Registry.register. Measured on the live registry:

  • the registered inputs on head are object,aggregate!,field,filter,format,prefix,suffix,dataSource (! = required). On base, object! carried the required mark and there was no dataSource;
  • validateTree on { type: 'element:number', dataSource: { object: 'contact' }, aggregate: 'count' } returns no diagnostic. On base it returned is missing required prop "object" and has no prop "dataSource".

The render-path changes come from useElementDataSource and from the filter merge, and they reach only a node that carries a binding:

  • a named view reads saved views and shows the shared loading panel while it resolves;
  • an unresolvable view, or a filter refused in either merge, shows the shared error panel;
  • a node with no dataSource resolves absent synchronously, so the properties form issues no new read, shows no new panel, and sends its filter unlowered. This is pinned: the control row asserts getObjectSchema is never called.

Pins: red before, green on head

File: elementNumber.dataSourceBinding-10909.test.tsx, 18 rows. The file was byte-identical in all three runs, and each base run used a temporary detached worktree that was removed afterwards.

run result
head 37bc45f Tests 18 passed (18)
base 733fd5a Tests 16 failed | 2 passed (18) — the 2 green rows are the properties-form control and the empty-object binding row
previous head 48d755d (rule A) Tests 6 failed | 12 passed (18)

The 6 rows red on the previous head:

  • the two AND rows (binding + properties filter, view + properties filter) and the refused-merge row are red on semantics;
  • "the binding filter scopes the aggregate", "a named saved view's filter scopes the aggregate" and the sort/limit whole-bag row are red on wire shape only. With a binding present, every filter source is now lowered to the ObjectQL AST before merging, as the gate does.

Rows:

  1. the dataSource form calls aggregate for the bound object and paints the value;
  2. dataSource.object wins over properties.object when both are set;
  3. control: the properties form is unchanged;
  4. the find() fallback reads the bound object when the adapter cannot aggregate;
  5. a binding that names no object supplies nothing, and the flat object stands;
  6. one bus event re-reads it, keyed on the resolved object;
  7. the key is the binding, not the flat object it outranks;
  8. filter: the binding filter scopes the aggregate;
  9. filter: properties.filter is AND-combined with the binding filter — both reach the aggregate, neither is dropped;
  10. filter: a named view's filter and properties.filter are both applied, AND-combined;
  11. filter: a merge the converter refuses reports on the error panel and aggregates nothing;
  12. view: a named saved view's filter scopes the aggregate;
  13. view: one that cannot be resolved reports and aggregates nothing;
  14. view: an unresolvable one does not fall back to properties.object — no object while it is unresolved;
  15. sort and limit are not read: the options bag stays whole with a binding and a view carrying both;
  16. limit is not read on the find() fallback either: a count is never capped;
  17. the registration declares dataSource as an object binding, and object is no longer required;
  18. the html tier accepts the dataSource form without a diagnostic (control in the same row: element:text still reports has no prop "dataSource").

Ablations at 37bc45f, through objectstack/scripts/ablation-replace.mjs in wrap mode with its trap-armed restore. Each was run over the pin file plus the three pre-existing element:number files (elementNumberFilterMembers-8071, elementReaders.invalidationRefetch-10623, element-number.contractEnvelope-6726), 33 rows in all. Each restore printed ok restored: blob == HEAD (3ab0d9a745a4) and git diff HEAD is empty.

# ablation red green
1 resolution line: (composed?.object ?? props.object) becomes (/* ablation-10909 */ props.object); blob 3ab0d9a745a4 to 875d8dfa0e4a 11 failed | 22 passed (33): rows 1, 2, 4, 6–10, 12, 15 and 16, the dataSource-form rows that reach the resolution line both controls, the refused-merge and unresolvable-view rows, the two registration rows, and all 15 rows of the three pre-existing files
2 AND merge: mergeFilterNodes(own.node, bound.node) becomes (/* ablation-10909-and */ bound.node ?? own.node), the rule A semantics; blob 3ab0d9a745a4 to 2a9bf06af87c 2 failed | 31 passed (33): exactly the two AND rows, 9 and 10 everything else
3 guard: unresolved || filterRefusal ? undefined : becomes /* ablation-10909-guard */ ; blob 3ab0d9a745a4 to c249c85fa79b 2 failed | 31 passed (33): exactly row 11 (refused merge) and row 14 (unresolved view beside a flat object) everything else

Census: element renderers and the dataSource binding

Every element:* registration is in @object-ui/components, and no other package registers one. The census probe rendered each registered element with dataSource: { object: 'contact' } and no flat object:

block object-bound? reads dataSource? html tier on dataSource
element:number yes (object) yes (this PR): aggregate(contact) accepted
element:record_picker yes (object) yes: find(contact) accepted
element:repeater yes (object, required) no: no read reports has no prop "dataSource" and the missing object
element:metadata_viewer names a METADATA subject (a state machine's object), not a record query no reports has no prop "dataSource"
element:text, element:divider, element:image, element:button, element:text_input, element:definition-list no no reports has no prop "dataSource"

element:form and element:filter have ComponentPropsMap rows but no objectui renderer. element:repeater is not a spec block: it has no PageComponentType member and no ComponentPropsMap row. Its declaration and its runtime agree, and the html tier reports the key, so this is an observation, not a finding.

Consumer sweep

The file set is the git grep hits for element:number, ElementNumberRenderer, elementDataSourceBlock, withElementDataSourceInput and ELEMENT_DATA_SOURCE_INPUT in tests, plus:

  • the html-tier manifest and html-tier dataSource declaration suites;
  • the registry-inputs parity suite and the element-data-source-input-injection render probe;
  • the record_picker data-source and malformed-filter pins;
  • the suites that render every element renderer generically.

Fix round 1 adds the gate-family filter-merge tests this change reuses: ElementDataSourceGate.malformedFilter-10789, ElementDataSourceGate.test, core filter-source-merge.test, and ObjectMetric.elementDataSource.test.

At 37bc45f, 34 files, run under the shared verify lock: Test Files 34 passed (34) · Tests 983 passed (983).

The full @object-ui/components suite ran at 75f027e (before this round) in three directory runs: 326 collected files, all green. This round changes only elements.tsx and its pin file inside that package. Both are covered above by the directories' own element:number files and by the sweep.

Gates

At 37bc45f. Each verdict is the gate's own line.

  • pnpm --filter @object-ui/components type-check (tsc --noEmit && tsc -p tsconfig.test.json), after pnpm --workspace-concurrency=2 --filter '@object-ui/components^...' build (8 of 47 projects): exit 0.
  • pnpm check:element-data-source-declaration: OK — 14 gate-consuming file(s) checked, 3 definition file(s) excluded; all reach the seam and take it from core.
  • node scripts/check-changeset-presence.mjs: 3 source file(s) of 2 released package(s) changed, and this change declares 1 changeset(s): .changeset/10909-element-number-datasource.md.
  • node scripts/check-changeset-no-major.mjs: No changeset declares a major bump. The frontmatter is minor.
  • pnpm check:changeset-claims: report-only. The same three pending changesets name touched files (6726-find-envelope-records-arms, 6783-readprops-degenerate-config-bag, 8067-component-input-member-kind); each paragraph is still true.
  • pnpm check:control-bytes: OK.
  • pnpm check:new-line-citations: VERDICT new-cross-file-line-citations: 0 new citation(s).
  • node scripts/check-doc-links.mjs: Links are valid across 17 scan roots.
  • eslint, a proven narrowing (--no-inline-config --format json over the three changed source and test files):
    1. Population from eslint's own config: ESLint.isPathIgnored answers false for all three.
    2. Count from the JSON: 3 files, 0 errors. elements.tsx has 24 warnings, the same per-rule split as base; the other two files have 0.
    3. Invariance: type-aware linting is off (no parserOptions.project or projectService), and the one custom rule reads no file from disk, so untouched files cannot move.
  • Carried from round 0, and not affected by this round's diff: check:handler-key-reads, check:designer-field-key-parity, check:component-surface-parity, check:unreferenced-sources, check:test-path-roots, check:vi-mock-specifiers, check:registry-bare-names, check:i18n-keys, check:doc-types, check:doc-fences, check:doc-example-ids and check:spec-symbols were green at 75f027e.
  • NOT MEASURED: apps/console type-check. Reason: its program needs every plugin's built declarations, and that closure build is beyond the foreground cap. The CI Type Check job owns it. The console edit is one MEMBER_PINS entry with two string fields.
  • NOT MEASURED: check:sdui-registration-pins. Reason: PREREQUISITE, no console bundle (exit 2). The performance-budget workflow runs it.
  • NOT MEASURED: check:doc-snippets and check:doc-examples. Reason: PREREQUISITE, unbuilt packages (exit 2). The guide edit adds no fenced snippet.

Serial

  • Open PRs, read through REST before opening: 19 PRs, all file lists (1,867 rows). None touches packages/components/src/renderers/basic/, the parity suite or content/docs/guide/data-source.md. Positive control: PR objectui#10908's packages/types/ files match the same grep.
  • packages/core is unchanged; this change only imports its existing toFilterNodeSafely and mergeFilterNodes.
  • git merge-tree --write-tree against a fresh origin/main 5c94589, fetched into a private ref: exit 0, tree 4c51202bf5. Main moved 20 commits since the base, and none of them touches the renderer, the parity suite, the guide, useElementDataSource, useResolvedFilter, the gate, the core data-source module, filter-converter, Registry.ts or validate.ts.
  • git merge-tree --write-tree against PR objectui#10908's head fe8f6a6: exit 0, tree 4bb57ac81c.

Fix round 1

This responds to the contract review FAIL at 48d755d, on text and one seat ruling. Object resolution, the unchanged properties form, the registration, the census and the pins held.

  • Seat ruling B, filter AND-combine. Implemented in the renderer with the gate's toFilterNodeSafely + mergeFilterNodes.
    • The precedence row flipped to assert that both filters reach the aggregate.
    • New rows: a view filter plus properties.filter; a refused merge taking the error panel with no aggregate call.
    • The registered filter description is the ruling's text verbatim. The guide paragraph and the changeset bullet say AND-combined.
    • record_picker is untouched.
  • Changeset:
    • the frontmatter becomes minor;
    • the Clause paragraph is replaced with the review's Clause-②: yes (widening) text verbatim;
    • "accepted by both validators" becomes "which the spec lint gate accepts, as objectui validate will once objectui#10908 arms the type";
    • the filter bullet now states AND-combine and the loud refusal.
  • PR body: line 2 is Clause-②: yes (widening).
  • Unresolved-guard pin: dataSource: { object: 'contact', view: 'no_such_view' } beside properties.object: 'contact' asserts no aggregate call and the error panel. The guard ablation reddens exactly that row and the refused-merge row.
  • MEMBER_PINS prose: rewritten for rule B. It no longer says the declaration carries "nothing about members"; it says the injected description lists the five members generically and the pin carries which of them this block reads.

Acceptance notes

  • This unblocks PR objectui#10908. It is the contract review's option (c) sequencing. With this landed, both validators, the html tier and the renderer tell one story about { dataSource: { object } }, and PR objectui#10908's arm (which accepts properties.filter beside a binding filter or view) now matches a renderer that honours both.
  • Clause-②: yes (widening). The published element:number manifest entry declares dataSource, and object is no longer required. The html tier, and the objectstack CLI's JSX gate that reads the manifest, now also accept a node that names neither object nor a binding, which paints the empty dash. That case is still reported on the JSON door by the spec lint gate (advisory), and after PR objectui#10908 by its arm when a bag is present. A runtime "no object named" notice, or a one-of check at the html tier, would be a follow-up card. Precedent: objectui#10508 made the same trade on calendar and gantt objectName.
  • Wire shape with a binding. When a binding is present, every filter source is lowered to the ObjectQL AST before it reaches aggregate() / find(), as ElementDataSourceGate does for object-metric. Without a binding, properties.filter is sent as authored, as before.
  • Studio is unchanged. Studio's block config for element:number stays properties-only and offers no dataSource editor.
  • The error-panel title "could not be resolved" is imprecise for a refused filter; the panel's message names the refused rule. record_picker shares the wording. This is a review nit, and the text is unchanged here.

Generated by Claude Code

…ct (objectui#10909)

ElementNumberRenderer read its object only from `properties.object`, so a
spec-valid `{ dataSource: { object }, properties: { aggregate } }` metric
issued no query and painted the empty dash. It now resolves the binding
through `useElementDataSource`, the way `element:record_picker` does:
`dataSource.object ?? properties.object`, one value for the fetch guard,
`aggregate` / `find` and the `useDataInvalidation` key. A named `view`
scopes the aggregate (an unresolvable one reports and aggregates nothing),
a binding filter wins over `properties.filter`, and `sort` / `limit` are
not read. The registration goes through `elementDataSourceBlock`, so it
declares `dataSource`, and `object` is no longer required.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
…d add its changeset (objectui#10909)

Declaring `dataSource` on element:number adds an object-armed input to a
covered block, so the registry-inputs parity census requires a member pin
for it. The pin is the renderer file that asserts which binding members
the metric reads and which it does not.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
… for the strict test project (objectui#10909)

`tsc -p tsconfig.test.json` refused `adapter.aggregate` as possibly
undefined on the optional-member fake. The aggregating fake and the
find-only fake are now two factories.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
…ctui#10909)

The data-source guide's table of blocks that consume `dataSource` gains the
`element:number` row (object, a view's filter, filter; no sort, no limit),
and says how the two `element:*` rows read the binding: directly, with a
binding member winning over the flat `properties` one.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 3 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/6726-find-envelope-records-arms.md

  • names components/src/renderers/basic/elements.tsx → packages/components/src/renderers/basic/elements.tsx — edited by this change

    | module | what it does | | --- | --- | | components/src/hooks/related-count-store.ts | related-list tab badge count | | components/src/renderers/basic/data-list.tsx | element:repeater rows | | components/src/renderers/basic/elements.tsx | element:number client-side aggregate | | components/src/renderers/basic/record-picker.tsx | element:record_picker options | | plugin-detail/src/renderers/record-activity.tsx | record:activity self-fetch | | plugin-detail/src/renderers/record-history.tsx | record:history self-fetch | | plugin-view/src/ObjectView.tsx | non-grid (kanban / calendar / gallery / timeline) fetch |

.changeset/6783-readprops-degenerate-config-bag.md

  • names elements.tsx → packages/components/src/renderers/basic/elements.tsx — edited by this change

    Five modules under packages/components/src/renderers/basic/ — elements.tsx, data-list.tsx, text-input.tsx, record-picker.tsx, metadata-viewer.tsx — each carried a copy of the same reader, { ...(schema?.props ?? {}), ...(schema?.properties ?? {}) }. ?? only replaces null/undefined, so a non-object bag went into the object spread and came back out as indexed keys: for properties: 'not-a-bag', the config bag a renderer received was { '0': 'n', '1': 'o', … '8': 'g' } — nine keys nobody authored. The five copies are now one readProps (renderers/basic/readProps.ts) that asks isConfigBag, and a degenerate bag on either side contributes no keys.

.changeset/8067-component-input-member-kind.md

  • names apps/console/src/__tests__/registry-inputs-spec-parity.test.ts → apps/console/src/__tests__/registry-inputs-spec-parity.test.ts — edited by this change

    A registration's type: 'array' said a value was a list and stopped there, so a member that drifted from @objectstack/spec was invisible to every layer that reads a declaration. page:header.actions is the measured cost: the contract declares z.array(z.string()) ("Action IDs"), the renderer read the members as ActionDef objects, and the repo-wide parity gate in apps/console/src/__tests__/registry-inputs-spec-parity.test.ts stayed green for the whole life of the drift because both sides carried the key and neither could say what was inside it. What settled it was a maintainer ruling, not a test — and even after the fix, "these are ids" survived only as English in the registration's description.

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with 3b469c8ea (merge-base with origin/main): 4 file(s) changed outside .changeset/, read against 1684 pending declaration(s) that publish a body (2283 pending in total). · run

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 330 chunks) 3102.6 KB 3104.5 KB
Main entry chunk (gzip) 149.4 KB 350 KB
Entry file index-DyI7nEd8.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.58KB 6.17KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.70KB 2.23KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.70KB 10.94KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.13KB 7.95KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 558.24KB 133.71KB
core (index.js) 9.93KB 3.94KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 227.61KB 63.16KB
fields (index.js) 261.01KB 66.28KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.40KB 12.91KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.32KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 51.96KB 14.83KB
plugin-charts (index.js) 84.09KB 22.93KB
plugin-chatbot (index.js) 197.72KB 46.92KB
plugin-dashboard (index.js) 137.82KB 36.70KB
plugin-designer (index.js) 215.78KB 44.42KB
plugin-detail (index.js) 233.51KB 61.80KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 161.21KB 41.41KB
plugin-gantt (index.js) 170.35KB 42.19KB
plugin-grid (index.js) 228.33KB 62.59KB
plugin-kanban (index.js) 48.43KB 15.11KB
plugin-list (index.js) 115.86KB 28.64KB
plugin-map (index.js) 22.90KB 7.62KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.17KB 12.20KB
plugin-timeline (index.js) 31.15KB 9.14KB
plugin-tree (index.js) 11.21KB 3.89KB
plugin-view (index.js) 88.55KB 22.21KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 119.16KB 39.05KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.03KB 1.86KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 7.50KB 3.05KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 6.16KB 2.71KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.22KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 3.83KB 1.49KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.26KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.27KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 48d755dfe19f613aa878fc3c8449265086ba7772

① Derived judgments

Object resolution: correct and complete.

  • object is computed once, as unresolved ? undefined : (composed?.object ?? props.object). That one value feeds:
    • the fetch guard;
    • aggregate and find;
    • the effect deps;
    • the useDataInvalidation key.
  • The resolution line is the only props.object read left in ElementNumberRenderer.
  • There is no field-metadata lookup. Currency comes from the tenant.
  • isElementDataSourceConfig needs a non-empty string object. So object: '', a non-string, or { view } without an object resolves absent, and the flat object stands. The spec gate's strName and PR fix(types,cli): element:number validates, with the spec's dataSource waiver (objectui#10872, batch 2) #10908's dataSourceSuppliesObject read it the same way.

useElementDataSource: the properties form is unchanged, as claimed.

  • With no binding, the hook returns absent. Its effect needs both object and view, so it never fetches. It returns no composed, so object and filter are exactly base's.
  • elementDataSourceBlock is a WeakSet add, read only by withElementDataSourceInput, which touches inputs only.
  • With a binding:
    • a named view triggers a getObjectSchema / listViews read and shows the loading panel;
    • an unknown view, an adapter that cannot list views, or a refused view-AND-binding merge gives missing, which shows the error panel.
  • Nit: the panel title "could not be resolved" is imprecise for a refused filter. record_picker has the same wording.

Filter precedence. Ruling: B (AND-combine). This is not a FAIL ground on its own; adopt it in the fix round that is owed anyway.

  • What the sources say.
    • The spec's ElementDataSourceSchema.filter says "Additional filter criteria … AND-combined with the filter of the named view". It says nothing about a props filter.
    • ComponentPropsMap['element:number'].filter says "Filter rules narrowing the aggregate".
    • objectstack has no renderer for this block. Its gate rules on object only (page-walk.ts: dataSource.object, then properties.object, then the page object).
    • record_picker's ?? is a documented rule, not an accident: its registered filter description carries an explicit PRECEDENCE clause ("dropped entirely rather than merged"). But the spec's filter docblock cites that ?? as the place where record_picker "carried two orthographies at two keys". That is history, not endorsement.
  • The four axes:
    • Real demand: neutral. H1 found no authored metric in the dataSource form.
    • Long-term soundness: favours B.
      • element:number and object-metric have identical rows in the guide table. Under A, the two metrics give different counts for the same authored pair.
      • The nine gate-wrapped blocks AND the filters.
      • The guide's own table intro calls a key "accepted and dropped" the defect this binding removes.
    • AI-error resistance: favours B.
    • Startup focus: marginally favours A. B costs about ten lines, one flipped pin row and one refusal row. record_picker keeps its rule; aligning it is not this card's work.
  • Replacement filter description for B: "Criteria the aggregate is scoped by. When a node-level dataSource binding also supplies a filter (its own, or the saved view its view names), the two are AND-combined: neither is dropped." The guide sentence and the changeset bullet change to match.
  • If the seat keeps A, the published description codifies it. With no author, flipping later is also free.

Registration and manifest.

  • Declaring dataSource (the injected ELEMENT_DATA_SOURCE_INPUT, with binding: 'object') and dropping object's required are true to the renderer. They are what seat ruling 5864951915 asked for.
  • Who reads required:
    • sdui-parser validateTree, which emits missing-required-prop at severity error. That is the JSX-page compiler and the save gate.
    • The objectstack CLI's JSX gate (compile, validate and lint), through the published sdui.manifest.json. element:number is in PUBLIC_BLOCKS.
    • Not the parity suite, which does not compare required. Not the designer either: block-config.ts hard-codes its own field list.
  • Hidden authoring error: yes.
    • On base, element:number with aggregate and neither object nor a binding drew missing-required-prop "object". At head, neither JSX gate reports it, and the runtime paints "—" silently, as it did on base.
    • It is still reported on the JSON door only:
    • Precedent: objectui#10508 made the same trade on calendar and gantt objectName.
    • Non-blocking, but it must be disclosed (changeset text in ②). A follow-up card should add a runtime "no object named" notice or a one-of check at the html tier.
  • Descriptions:
    • object's is true.
    • filter's is true of A.
    • The injected dataSource description advertises { object, view, filter, sort, limit } on a block that reads three members. object-metric does the same, and the guide row discloses it. The MEMBER_PINS line "nothing about members" overstates this (test prose, nit).

Pins and ablation.

  • By reading the test source: 15 rows. On base, 13 are red; the 2 green are the FLAT control and the object: '' row. This matches the dev's count.
  • The dev's ablation of (composed?.object ?? props.object) reddens exactly the 10 BOUND rows that reach an adapter call.
  • It does not isolate the whole line:
    • The unresolved ? undefined : half is unpinned. Removing it leaves all 15 rows green, because BOUND carries no flat object.
    • The missing row: dataSource: { object: 'contact', view: 'no_such_view' } beside properties.object: 'contact', asserting no aggregate call.
    • A view filter beating properties.filter is also unpinned.
    • Non-blocking.

Census: true against source.

  • The element registrations are text, divider, image, button, number, record_picker, text_input, metadata_viewer, definition-list and repeater.
  • Only repeater is object-bound and ignores the binding. It is not a spec element: type, and the html tier reports has no prop "dataSource" on it, so it fails loudly, not silently.
  • No unfiled defect.

Docs and changeset.

  • The guide row (✅, filter, ✅, single value, single value) mirrors object-metric and is true. The new paragraph is true of A.
  • Two changeset sentences are false:
    • "— accepted by both validators —". On main, objectui validate still refuses element:number at type; the pending 10872-public-block-zod-arms.md says "still refused at type: element:number". Replace with: "— which the spec lint gate accepts, as objectui validate will once objectui#10908 arms the type —".
    • Bullet 3, "which still applies when the binding carries none". A view filter with no binding filter also drops properties.filter. Replace with: "which still applies only when neither the binding nor its view supplies one."

Compatibility with PR #10908.

  • It agrees on object:
    • a non-empty string binding supplies the object;
    • an empty, non-string or non-record binding does not;
    • a present flat object is left to the row.
  • Three mismatches remain, none blocking:
    • (a) The arm accepts properties.filter beside dataSource.filter or dataSource.view. Under A the renderer drops the flat filter; B removes this mismatch.
    • (b) The arm accepts the binding's sort and limit, which the renderer never reads. This is disclosed in the guide and is spec-level.
    • (c) The arm accepts a bag-less { type, dataSource }, which paints "—" because it has no aggregate. This caveat is inherited from batch 1.

② Semver level

Clause-②: yes (widening). The no in the PR body and the changeset is wrong.

  • Why: the published element:number manifest entry is a public accept set, read by the html tier and the objectstack CLI. It gains dataSource, and object loses required.
  • What yes requires: at least minor (objectstack AGENTS.md, Post-Task Checklist item 3). No CI job enforces this: Changeset Bump Policy checks only that no changeset declares major.
  • Precedent:
    • objectui#10552 (hideEmpty) and objectui#10484 (icon) each declared a registration input the html tier then accepts. Each is marked "Clause-②: yes — the authoring surface widens by one key" and minor, and both are on a tag outside the public tier. This change is inside it.
    • objectui#10508 (relaxed objectName and declared inputs, patch) carries no Clause-② line, so it does not govern.
  • Required: '@object-ui/components': minor. Never major.
  • Replacement for the changeset's last paragraph: "Clause-②: yes (widening) — no export moves, but the published element:number entry in sdui.manifest.json widens: it declares dataSource, and object is no longer required. The html tier, and the objectstack CLI's JSX gate that reads this manifest, therefore accept a node bound through dataSource alone — and also one that names neither object nor a binding, which no longer draws missing-required-prop and paints the empty dash."
  • PR body: line 2 becomes Clause-②: yes (widening). The seat restates this against claim 5866532141.

③ Boundary flags

Local-runs: none

  • CI at head, not final. 42 check runs:
    • 36 success;
    • 3 skipped: both coverage jobs and dependabot;
    • 3 in progress: Test shard 1/8, Test shard 2/8, Spec Main Shape Gate.
  • Eager closure: 3102.6 of 3104.5 KB (✅), leaving 1.9 KB of headroom.
  • merge-tree against main 0059661b47: clean, tree 42434b6ce1. Main moved 13 commits, none on a dependent file.
  • merge-tree against fix(types,cli): element:number validates, with the spec's dataSource waiver (objectui#10872, batch 2) #10908's head fe8f6a6aad: clean, tree 30145c5c4f.
  • Other open PRs: 10 are open. None touches the five files, renderers/basic/, or the element-data-source seam.
  • check-governed-merges: NOT governed (0 of 5 paths), 430 lines.
  • PR state:
    • It is a draft.
    • The assignee is os-elon-musk.
    • needs:contract-review is present. A FAIL does not remove it.
  • Cross-repo: objectstack's checked-in sdui.manifest.json still has element:number object required: true and no dataSource. The next objectui pin bump regenerates it with this widening.
  • fix(types,cli): element:number validates, with the spec's dataSource waiver (objectui#10872, batch 2) #10908: it stays held until this lands, and nothing in it needs to change.
  • The dev's open question (filter precedence) is answered in ①: B, the seat's call.

Implemented-by: claude/issue-10909-element-number-datasource
Reviewed-by: session_014mXUNuFomfj24w7s1pZzhN

VERDICT: FAIL

Required fix round (text only):

  1. Changeset frontmatter becomes minor.
  2. Replace the Clause paragraph with the ② text.
  3. PR body line 2 becomes Clause-②: yes (widening).
  4. Replace the two false changeset sentences in ① as given.

Recommended in the same round, the seat's call:

  • filter rule B;
  • the pin row for the unresolved guard.

…he binding's filter (objectui#10909, fix round 1)

Seat ruling B on the open question: with a `dataSource` binding present,
`properties.filter` is AND-combined with the binding's filter and its
view's, lowered and merged the way `ElementDataSourceGate` does
(`toFilterNodeSafely` + `mergeFilterNodes`). Neither is dropped; a refused
merge takes the configuration-error panel and aggregates nothing. The
properties form with no binding is unchanged.

Pins: the precedence row flips to assert both filters reach the
aggregate; new rows for a view filter beside properties.filter, a refused
merge, and the unresolved-view guard beside a flat object. The registered
`filter` description, the guide paragraph and the changeset say the same.
The changeset becomes `minor` with `Clause-②: yes (widening)`, and its two
sentences the review found false are replaced. The MEMBER_PINS prose says
what the injected declaration does and does not carry.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 330 chunks) 3102.9 KB 3104.5 KB
Main entry chunk (gzip) 149.4 KB 350 KB
Entry file index-DMPh34mE.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.58KB 6.17KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.70KB 2.23KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.70KB 10.94KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.13KB 7.95KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 558.56KB 133.87KB
core (index.js) 9.93KB 3.94KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 227.61KB 63.16KB
fields (index.js) 261.01KB 66.28KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.40KB 12.91KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.32KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 51.96KB 14.83KB
plugin-charts (index.js) 84.09KB 22.93KB
plugin-chatbot (index.js) 197.72KB 46.92KB
plugin-dashboard (index.js) 137.82KB 36.70KB
plugin-designer (index.js) 215.78KB 44.42KB
plugin-detail (index.js) 233.51KB 61.80KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 161.21KB 41.41KB
plugin-gantt (index.js) 170.35KB 42.19KB
plugin-grid (index.js) 228.33KB 62.59KB
plugin-kanban (index.js) 48.43KB 15.11KB
plugin-list (index.js) 115.86KB 28.64KB
plugin-map (index.js) 22.90KB 7.62KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.17KB 12.20KB
plugin-timeline (index.js) 31.15KB 9.14KB
plugin-tree (index.js) 11.21KB 3.89KB
plugin-view (index.js) 89.15KB 22.35KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 119.16KB 39.05KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.03KB 1.86KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 7.50KB 3.05KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 6.16KB 2.71KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.22KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 3.83KB 1.49KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.26KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.27KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 37bc45f74c0a26cd1fdce66e9f99a6534aff0d91

① Derived judgments

This is a delta review of 48d755dfe1..37bc45f74c (one commit, five files) against record 5867599385. Points that record found sound are not re-litigated.

The merge is the gate's own merge.

  • It uses the same helpers and the same operand order. ElementDataSourceGate runs toFilterNodeSafely(base.filter), then toFilterNodeSafely(composed.filter), then mergeFilterNodes(own.node, bound.node). The renderer does exactly this with props.filter and composed.filter.
  • Refusals are handled the same way:
    • A refusal comes back as a value, never as a throw.
    • It is never merged as "no filter".
    • It sets object to undefined, so the effect makes no aggregate or find call, and useDataInvalidation gets no key.
  • The no-binding path is behaviourally identical to the old one. With !composed, the memo returns props.filter by reference and filterRefusal is undefined. The object expression and the render condition then reduce to base's. The pre-existing elementNumberFilterMembers-8071 whole-bag pin still guards the raw shape.
  • useResolvedFilter now runs on the merged value, and the AST shape is fine for it.
    • resolveFilterPlaceholders and resolveDateMacros walk any array or plain object and replace whole-token string leaves.
    • viewFilterRuleToNode passes rule.value through untouched. It only refuses an array on a single-valued operator, or a bad icontains comparand. So {current_user_id} and the date macros reach the resolver intact.
    • isSameAuthoredFilter compares arrays by structure, so a changed composed identity does not refetch.
    • ObjectMetricWidget resolves placeholders after the gate's merge in the same order.

Wire shape: measured by reading, and accepted everywhere element:number sends it.

  • data-objectstack aggregate(): element:number's bag { field, function, groupBy: '_all', filter } takes the analytics branch. lowerAnalyticsFilterForWire then runs translateFilterArray:
    • a lowered [['status','equals','hot']] is a legacy flat array and passes child-wise;
    • ['and', [[..]], [[..]]] maps its children the same way;
    • locked @objectstack/spec@17.4.0 isFilterAST accepts it (equals, before and after are all in AST_OPERATOR_MAP at that tag);
    • lowerFilterAST recurses the legacy flat array and the and node to the same FilterCondition the rule array produces.
  • data-objectstack find: the $filter fallback goes through the same translateFilterToAST.
  • object-metric precedent: it sends the gate-merged AST to the same ds.aggregate(objectName, { …, filter }) position (in ObjectMetricWidget) and the same find(objectName, { $filter }). So element:number now joins an exercised path, not a new one.
  • Other adapters:
    • ApiDataSource.aggregate JSON-stringifies whatever it is given, so it does not care about the shape.
    • ValueDataSource.aggregate ignores filter entirely. That was already true, for both shapes.
    • ValueDataSource.find lowers through toFilterNodeSafely, and an AST passes through it.
    • MockDataSource reads no filter.
    • Neither apps/console nor app-shell wraps aggregate or find.
  • No adapter reads the filter as a rule array.

Refused-merge panel. A refused merge renders ElementDataSourceErrorPanel (element-number-datasource-error, role="alert") with the refusal's message, and makes no call.

  • This is the seat-ordered missing path, and it matches the twin: record_picker answers its own refusal (objectui#10789) with the same panel.
  • The gate itself draws ElementDataSourceMalformedFilterPanel instead. That difference is a declared deviation.
  • The "could not be resolved" title nit carries over. Non-blocking.

Texts.

  • Verbatim, checked byte for byte:
    • the filter description matches the ruling text;
    • the changeset's closing paragraph matches the record's Clause-②: yes (widening) text;
    • sentence 1's replacement matches the record.
  • Sentence 2 was replaced wholesale by the AND-combine bullet. That is correct: the record's replacement was written for rule A and said "change to match" under B.
  • Every other changed sentence is true against the code: the changeset bullet, "the same configuration-error panel, naming the refused rule", the guide paragraph (record_picker substitutes, element:number AND-combines, refusal shows the panel), the header docblock and the pin-file header table.
  • Nit, non-blocking. The changeset says "the rule every block behind ElementDataSourceGate applies". Four gate-wrapped blocks map no filter: object-form, embeddable-form, object-master-detail-form and detail-view. Optional replacement: "the rule every block behind ElementDataSourceGate that reads a filter applies".
  • record_picker is untouched: every hunk sits in ElementNumberRenderer or its registration.
  • MEMBER_PINS: the prose is softened ("lists the binding's five members generically … does not say which of them THIS block reads"). It also now carries the unresolved-view and AND rows.

Pins and ablations, checked against the test source. There are 18 rows.

  • The dev's counts are consistent with the source:
    • base: 16 red, with the FLAT control and the object: '' row green;
    • previous head: 6 red (rows 9–11 on semantics, rows 8, 12 and 15 on wire shape; row 14 green because the guard was already there);
    • head: 18 green.
  • Ablation 2 (bound.node ?? own.node) reddens only rows 9 and 10. Row 11 refuses before the merge; rows 8, 12 and 15 have a single source.
  • Ablation 3 removes the whole guard and reddens only rows 11 and 14. Reading each half alone:
    • dropping only unresolved still reddens row 14;
    • dropping only filterRefusal still reddens row 11;
    • so both halves are pinned.
  • The three re-pinned rows still assert the scoped filter's content. BINDING_NODE and HOT_NODE are literal triples written independently of the renderer's helpers, compared across the whole bag, so they do not accept just any AST.
  • Unpinned, correct by reading, non-blocking:
    • a context token through the lowered path;
    • the find() fallback carrying a lowered filter under a binding;
    • view plus binding filter plus properties.filter together.

② Semver level

  • minor, Clause-②: yes (widening). Both are fixed on the branch: the frontmatter is '@object-ui/components': minor, and the closing paragraph is the record's text verbatim. Never major.
  • PR body: line 2 on the live PR still reads Clause-②: no. The dev's replacement draft has Clause-②: yes (widening) on line 2, and nothing in the code contradicts it. The seat applies it at landing.

③ Boundary flags

Local-runs: none

  • CI at head is final. 43 check runs:
    • 40 success;
    • 3 skipped: both coverage jobs and dependabot;
    • none pending.
    • The Vercel status is success.
  • Eager closure: 3102.9 of 3104.5 KB (PASS), leaving 1.6 KB of headroom. That is 0.3 KB more than round 0, posted by Bundle Analysis on this head (comment 5867742500).
  • merge-tree against main 5c94589f03: clean, tree 4c51202bf5.
    • Main has moved 20 commits since base 733fd5ac65.
    • One of them touches packages/data-objectstack/src/index.ts: ac15833eb1 (dataset 403 typing) and the citation re-qualification in 1dae95a41b.
    • Neither touches aggregate()'s analytics filter lowering or find's translation.
    • The dev's list of dependent files leaves data-objectstack out. The wire-shape change now makes it a dependent file, but nothing moved on that path.
  • merge-tree against fix(types,cli): element:number validates, with the spec's dataSource waiver (objectui#10872, batch 2) #10908's head fe8f6a6aad: clean, tree 4bb57ac81c.
  • PR state: it is a draft, the assignee is os-elon-musk, and needs:contract-review is present.
  • Declared deviations: all accepted.
    • With a binding present, every filter source reaches the adapter lowered to the AST. This is the gate family's shape, and it is accepted by every adapter above.
    • A refused merge shows ErrorPanel, not the gate's malformed-filter panel. The seat ordered it, and it matches record_picker.
    • The dev added a third ablation beyond the two ordered.
  • Follow-ups the record already names, non-blocking:
    • a runtime "no object named" notice, or a one-of check at the html tier;
    • optionally, the error-panel title for a refused filter.

Implemented-by: claude/issue-10909-element-number-datasource
Reviewed-by: session_014mXUNuFomfj24w7s1pZzhN

VERDICT: PASS

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review September 28, 2026 10:22
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Sep 28, 2026
Merged via the queue into main with commit dd0d78f Sep 28, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-10909-element-number-datasource branch September 28, 2026 10:36
akarma-synetal pushed a commit to akarma-synetal/objectui that referenced this pull request Oct 7, 2026
… bare apiMethods-card number (objectui#10803, batch 7) (objectstack-ai#10962)

Part of objectstack-ai#10803
Clause-②: no

Dispatched implementation of the `domain:ui` seat objectstack-ai#1 claim (comment
`5867587761`) on objectui#10803, batch 7, session
`https://claude.ai/code/session_01DuWo5bdP9SdVebamn99GGk`. Citations
only: no sentence's claim moves, and every edited pending changeset's
frontmatter is byte-identical. The only runtime text that moves is two
console warnings, one in `@object-ui/app-shell` and one in
`@object-ui/plugin-detail`, which lose their dead pointer and nothing
else (amendment `5860244997`, Q1 = A; `patch` changeset). No test pins
any changed text: the literal-anchor sweep below finds no specific
anchor, so no test file is edited.

This batch carries release `5866922219`'s two lists:
- the **30 `objectstack#N` citations that answer 404**, in the card's
two classes (pending changeset prose and non-test `packages/*/src`);
- the **28 bare `objectstack-ai#3391` lines in 10 files** that mean objectstack's
apiMethods whitelist card, which batch 6 fixed at 2 other sites.

## Why `Part of`, not a closing line

Both lists read **0** after this batch (**Census**). The brief's rule
was a closing line if the card's lists all read 0. They do, but reading
the sentences found **10 more lines in the same two classes that cite a
dead objectstack number written bare**, three numbers in all
(**Acceptance notes** 1). Triage item 3 puts a dead number found later
in these classes on this card, so the card is not finished. Whether it
carries them as a batch 8 or closes is the seat's call.

## Premise, re-measured on `origin/main` `3b469c8ea` (the branch point)

- **Every distinct `objectstack#N` in the two in-scope classes.** 372
numbers (the one objectstack issue URL in these classes names 6227,
which is among them). Each was read once with REST `GET
/repos/objectstack-ai/objectstack/issues/N`:
  - 341 answer 200;
- 1 answers 301: objectstack#14026, transferred to objectui#10102, which
batch 6 re-qualified;
  - **30 answer 404**, exactly the 30 batch 6 listed.
- **The 30, read again.** A second `issues/N` read of each answers 404
(30 of 30), and `pulls/N` answers 404 for all 30. Lit controls in the
same run: objectstack#3391, objectstack-ai#3720 and objectstack-ai#3546 answer 200 as issues, and
`pulls/13267` answers 200.
- **objectstack-ai#3391 and objectstack-ai#3546, both repositories.**
- objectui#3391 is the record-header api-action placeholder card,
unrelated.
- objectstack#3391 is the apiMethods whitelist contract card: "UI 操作按钮与
apiMethods 白名单一致性契约落地". Its body names the effective operation set,
`/me/permissions`, the 405 import refusal and export derived from list,
which is what each of the 28 sentences says.
  - objectui#3546 is the missing-i18n-keys card, unrelated.
- objectstack#3546 is "detail/form 面的 edit/delete 按钮接入服务端 effective
操作集", the inline-edit gate the two paired lines describe.
- **objectstack history.** Read from a full, not shallow, treeless clone
of objectstack `main` (`git rev-parse --is-shallow-repository`: false).
- Every objectstack sha this PR cites is an ancestor of objectstack
`main` (`git merge-base --is-ancestor`, exit 0): the 24 this PR adds to
the tree, the 3 its edited sentences already cited (`c459da6bc`,
`89448a52b`, `9bd4344e4`), and the 7 this body names besides.
  - `git rev-parse --short=9` returns the same 9 characters for each.
- Control legs in the same clone: the head of the open PR
objectstack#20421 (`a22b90fc0`) answers exit 1; the known ancestor
`51789064` answers exit 0.
- **The one objectui sha.** `7a197e7c5` is an ancestor of the branch
point, exit 0. Control legs: the head of PR objectui#10945 answers exit
1, and `5f789538d` answers exit 0. This checkout is not shallow.
- **A cross-check, not the method.** objectstack's own sweep of dead
tracker citations in its tree (objectstack#19123's landing `66e266c93`,
its stages `21ab41041`, `5cf58eb16` and `0d7ed5a37`, and `f415bcf18`)
anchored eight of these numbers in its own files. For each of the eight
(objectstack-ai#5970, objectstack-ai#6483, objectstack-ai#9934, objectstack-ai#10485, objectstack-ai#11330, #11846, #12868 and #17147) it
chose the same commit this PR cites.
- Every edited changeset is pending: it is present in `.changeset/` on
`main`.

## Census (the enumeration pin for this batch)

The 30 numbers (REF = a commit or tree):

```
git grep -nE 'objectstack#(5970|5976|6038|6124|6281|6331|6450|6483|6515|9933|9934|10354|10485|10695|11330|11507|11513|11658|11703|11753|11846|12009|12868|13117|13670|16126|17147|17762|17987|18012)([^0-9]|$)' REF -- '.changeset/*.md' 'packages/*/src/**' ':!**/__tests__/**' ':!**/*.test.*' ':!**/*.spec.*' ':!**/test/**' ':!**/tests/**' | wc -l
```

The bare `objectstack-ai#3391`, with the same pathspec:

```
git grep -nE '(^|[^0-9A-Za-z_#/])objectstack-ai#3391([^0-9]|$)' REF -- '.changeset/*.md' 'packages/*/src/**' ':!**/__tests__/**' ':!**/*.test.*' ':!**/*.spec.*' ':!**/test/**' ':!**/tests/**' | wc -l
```

| REF | the 30 | bare `objectstack-ai#3391` |
|:--|:--|:--|
| `3b469c8ea` (branch point) | **82**: 26 changeset lines in 24 files,
56 src lines in 39 files | **28** in 10 files |
| `c292a6400` (this head) | **0** | **0** |
| this head merged with `main` `5c94589f0` (`git merge-tree
--write-tree`, clean, tree `bba27eece`) | **0** | **0** |
| `5c94589f0` (`main` alone) | 82 | 28 |

- Lit controls on the same instruments at this head: live
objectstack#10856 reads 4 lines (4 at the branch point);
`objectstack#3391` reads 32 lines, against 3 at the branch point (28
re-qualified here, and this PR's sweep changeset names it once).
- **Out of scope, as it stands** (whole tree at this head, unfiltered):
- the 30 numbers: 84 test lines in 47 files, 1 scripts line, 2 lines in
2 `apps/console` files, 2 package READMEs (`auth`, `react`), 11 lines of
published `CHANGELOG.md` history in 8 files; 0 `.github`, 0 governed, 0
`content/docs`;
- bare `objectstack-ai#3391`: 12 test lines in 9 files and 23 `CHANGELOG.md` lines in
8 files.

## Citation form

- **An objectstack commit** is written the way batch 6 wrote its
stand-ins: objectstack and the 9-character backticked sha of the commit
on objectstack `main` that landed the change the sentence rests on.
- **A dead card beside its own dead pull request** collapses to that
pull request's squash commit (objectstack-ai#5970 with PR objectstack-ai#6450, objectstack-ai#10485 with PR
objectstack-ai#10695).
- **A dead number beside the live landing it already names** is dropped:
#11846 beside PR objectstack#12718, #16126 beside PR objectstack#16920,
#12868 beside objectstack `c459da6bc`, and #12009 beside objectstack
`89448a52b` (**Special cases** 3).
- **A ruling the dead card carried** is cited by its date, with the
commit that executed or recorded it, as batches 3 to 6 did for objectui
rulings.
- **One sentence cites this repository's commit**, `7a197e7c5`, because
the change it names landed here (objectstack-ai#6331).
- **Runtime text carries no sha.** In the two console warnings the dead
pointer is dropped (**Special cases** 8).
- **The bare `objectstack-ai#3391`** becomes `objectstack#3391`, and on the two lines
that write `objectstack-ai#3391/objectstack-ai#3546`, `objectstack#3391/objectstack#3546`.

## Mapping, the 30 numbers

Lines / files are the branch-point census for that number (a line naming
two of them counts under both).

| dead number | resolution | what that commit carries | lines / files |
|:--|:--|:--|:--|
| objectstack-ai#5970 | objectstack `97e7e3caa` | "unify ActionSchema.visible/disabled
on one condition shape (objectstack-ai#6450)", body "(objectstack-ai#5970)": `visible` gains the
boolean arm | 2 / 1 |
| objectstack-ai#6450 (PR) | the same `97e7e3caa`, its squash | as above; the card /
PR pair collapses | 2 / 1 |
| objectstack-ai#5976 (PR) | objectstack `795b6e1aa`, its squash | "5 值子集改名
`HttpMethodSubset`" | 1 / 1 |
| objectstack-ai#6038 | objectstack `7618ee814` | "key a container's default `list`
`_views` name by the runtime identity": leg 2 of 3 of the
objectstack#5164 ruling, the `packages/lint` half | 1 / 1 |
| objectstack-ai#6124 (PR) | objectstack `b3c1f3cd5`, its squash | "key `_views`
translations by the runtime view identity"; "The extractor now ASKS the
composer for the key" | 1 / 1 |
| objectstack-ai#6281 (PR) | objectstack `85ec26d28`, its squash, 2026-08-07 | "SDUI
props — enforce or remove (objectstack-ai#5775) (objectstack-ai#6281)": the shared
`PageContainerProps`, whose single key is `children`, for `page:section`
/ `page:footer` / `page:sidebar`, which were `EmptyProps` | 1 / 1 |
| objectstack-ai#6331 | objectui `7a197e7c5` | this repository's "SchemaForm reads the
canonical `visibleWhen`, reviving every metadata-form predicate
(objectstack#6331)" | 1 / 1 |
| objectstack-ai#6483 | objectstack `ee58392e1` | "ADR-0005 白名单强制 … (objectstack-ai#6483)"; its diff
carries the sentence the comment quotes, "Runtime-created sets … ride
`allowRuntimeCreate` (still `true`) and keep working" | 1 / 1 |
| objectstack-ai#6515 (PR) | objectstack `2fdb36eb9`, its squash | "SpecifierSchema
gains a closed `valueDomain` enum": "`bcp47_locale` is deliberately not
in the vocabulary", because `localization.locale`'s options ARE the
shipped catalogs | 1 / 1 |
| objectstack-ai#9933 | objectstack `d5552ca13` | "admit columnState as an explicitly
runtime-only view-overlay key" (subject ending "(objectstack-ai#9996)"; "(objectstack-ai#9933)" is
on the message's first body line), on the overlay faces including
`viewItemWireFields` | 3 / 3 |
| objectstack-ai#9934 | objectstack `79c46da90` | "producer-side user-facing marking
for hook refusal messages — userMessage channel (objectstack-ai#9934)":
`ApiErrorSchema.userMessage`, the contract half of the objectui#5210
split | 10 / 9 |
| objectstack-ai#10354 (PR) | objectstack `9e04c3e35`, its squash | "let the publish
door state the package it is promoting"; its changeset and code comment
carry the key-presence / `no_draft` warning `ResourceEditPage.tsx`
points at | 4 / 3 |
| objectstack-ai#10485 | objectstack `35ad101bc` | "retire the `themes` carrier key
and ThemeSchema (objectstack-ai#10485, ADR-0049) (objectstack-ai#10695)": "Ruled B (退役授权面,
2026-08-21)", "delete ui/theme.zod.ts whole" | 15 / 13 |
| objectstack-ai#10695 (PR) | the same `35ad101bc`, its squash | as above; the card /
PR pair collapses | 6 / 6 |
| objectstack-ai#11330 | objectstack `a9ee98992` | "manifest.runtime trust-tier text
states publish-gate-only enforcement truthfully", the trust-tier half
(**Special cases** 2) | 1 / 1 |
| objectstack-ai#11507 | objectstack `88b9d749a` | "declare sys_activity.type as an
open, author-extensible vocabulary": "Maintainer ruling 2026-08-24,
direction 4" | 13 / 9 |
| objectstack-ai#11513 | objectstack `e170b0ae5` | "lock package-declared permission
sets at the save door; clone to customize", quoting the 2026-08-24
ruling 「同意 第一步(创业阶段,Salesforce 式)」 | 3 / 3 |
| objectstack-ai#11658 | objectstack `1a6a19c31` | "open RecordActivityProps.types to
author-contributed activity kinds"; its message names objectstack-ai#11658 as the card
it settles, and it executes the 2026-08-24 ruling | 1 / 1 |
| objectstack-ai#11703 | objectstack `5cb62d88b` | "make clone_permission_set carry
all five copied facets"; its message names objectstack-ai#11703 as the card it
settles: the silent-grant-loss shape | 1 / 1 |
| objectstack-ai#11753 | "the 2026-08-25 ruling whose spec half is objectstack
`0e4e51b0a`" | `ActionParamSchema.carryOver`, whose changeset reads
"(objectstack-ai#11753 ruling, spec half; #11992)" and "The maintainer's 2026-08-25
ruling on objectstack-ai#11753" | 2 / 2 |
| #11846 | objectstack `0c2334f6c`; dropped beside PR objectstack#12718
| "retire preview mode — the RuntimeMode 'preview' value and the whole
PreviewModeConfig block (#12718)" | 3 / 3 |
| #12009 | dropped beside objectstack `89448a52b` | the card of the
`AUTH_SSO_PROVIDER_SCHEMA` removal, whose landing the line already cites
(**Special cases** 3) | 1 / 1 |
| #12868 | dropped beside objectstack `c459da6bc` | the line already
cites the commit that executed the ruling; objectstack's own `f415bcf18`
anchors #12868 to the same `c459da6bc` | 1 / 1 |
| #13117 (PR) | objectstack `225e7690f`, its squash | "Readiness read
for the Phase-2 members … global:search and global:notifications both
have shipped platform data sources, so per the ruling both STAY
declared" | 1 / 1 |
| #13670 | "maintainer ruling 2026-08-31, option 2, recorded in
objectstack `8c6a7fc0b`" | "The #13670 ruling settled the question:
text's intended evaluation channel is `content` alone" | 1 / 1 |
| #16126 | dropped beside PR objectstack#16920 | PR objectstack#16920
(200) names #16126 in its body as the card it settles; merged 2026-09-08
as `859ded3ec` | 2 / 2 |
| #17147 | objectstack `aaacf1d5c` | "the install-time granted
permission set is REGISTERED at load and refuses nothing — say so, and
pin the measurement (#17147)", the measurement on `9bd4344e4` | 2 / 2 |
| #17762 | objectstack `4342c9923` | "guard three data lookups against
Object.prototype fall-through"; its message names #17762 as a card it
settles, `classifyFilterToken` among the three lookups | 1 / 1 |
| #17987 | objectstack `e233db9db` | "declare element-level `navigation`
on object-kanban / object-calendar …"; its message names #17987 as the
card it settles, and its Downstream note: objectui#8652 waits on it,
unlock criterion a released, installable `@objectstack/spec` (**Special
cases** 1) | 2 / 2 |
| #18012 | objectstack `176b03582` | "`$between` requires two non-blank
endpoints (#18012)": "Ruling executed: decision batch objectstack-ai#146 item 5,
**letter A**" | 3 / 3 |

The 28 `objectstack-ai#3391` lines, all now `objectstack#3391`: `ObjectDataPage.tsx`
(3) and `ObjectView.tsx` (2) in app-shell; `managedBy.ts` (5);
`MePermissionsProvider.tsx` (2), `PermissionContext.ts`,
`PermissionProvider.tsx`; `fieldWriteGate.ts`; `ImportWizard.tsx` (6),
`ObjectGrid.tsx` (4); `ListView.tsx` (3). Each was read: every one names
the server's effective API operation set, `/me/permissions`
`apiOperations`, or the 405 import refusal.

## Special cases (the judgement calls)

1. **#17987, two sentences.**
- `ObjectTree.tsx`: "blocked on objectstack#17987, whose unlock
criterion is a released `@objectstack/spec` carrying the declaration
being installable here" becomes "blocked on objectstack `e233db9db`,
whose unlock criterion …". That commit's Downstream note states the same
criterion.
- `ObjectCalendar.tsx`: "that card is `pm:blocked` on objectstack#17987"
becomes "that card waits on objectstack `e233db9db`". The label word is
not kept, because objectui#8652's label reads `pm:on-hold` today
(measured); "waits on" is the phrase `e233db9db`'s own note uses for
that card.
2. **objectstack-ai#11330.** "it is objectstack#11330's half of the same panel"
becomes "it is the trust-tier half of the same panel, which objectstack
`a9ee98992` settled separately". `aaacf1d5c`'s message calls objectstack-ai#11330 "the
sibling half of this very sentence", ruled the same way on 2026-08-30,
and `a9ee98992` (2026-08-30) is that half's landing.
3. **#12009 collapses into the sha beside it.** objectui#6910's body and
ruling comment `5534414562` name "objectstack#12009 / PR #13413"
together as the one `AUTH_SSO_PROVIDER_SCHEMA` precedent, a card and its
pull request. Batch 6 replaced PR #13413 with its squash `89448a52b`, so
the card goes the way of batch 3's objectstack-ai#5401 / objectstack-ai#5505 pair.
4. **objectstack-ai#11753, two sites.** The card carried the ruling, and `0e4e51b0a`
is its spec half. Both sites keep "ruling" as the antecedent that
`ActionParamDialog.tsx`'s next paragraph ("The ruling's point …") reads.
5. **objectstack-ai#10354 in `ResourceEditPage.tsx`.** "since objectstack#10354
`doPublish` states" gains a comma, "since objectstack `9e04c3e35`,
`doPublish` states", so two adjacent code spans do not read as one.
6. **objectstack-ai#11507 in the 8137 changeset.** "objectstack#11658 executing the
maintainer's 2026-08-24 ruling on objectstack#11507" becomes
"objectstack `1a6a19c31` executing the maintainer's 2026-08-24 ruling":
the executing commit is named, and the ruling is cited by its date.
7. **Line breaks moved** where the stand-in is longer or shorter:
`ActionRunner.ts` (two sites), `ActionParamDialog.tsx`, `theme.ts`,
`theme.zod.ts` (two sites), `index.zod.ts` and the metadata-admin
`i18n.ts` comment, where "ruling on" became "ruling of 2026-08-24,".
8. **The runtime strings.** Only the listed text moves.

| file | member | before | after |
|:--|:--|:--|:--|
| `app-shell/src/layout/activityItemType.ts` | the `console.warn` in
`warnUnmappedActivityType` | "… `sys_activity.type` is author-extensible
(objectstack#11507, ruled 2026-08-24) and is not validated on write …" |
"… `sys_activity.type` is author-extensible (ruled 2026-08-24) and is
not validated on write …" |
| `plugin-detail/src/renderers/recordActivityFeed.ts` | the `warnOnce`
message in `warnUnknownActivityType` | "… `sys_activity.type` is
author-extensible (objectstack#11507, ruled 2026-08-24) and is not
validated on write …" | "… `sys_activity.type` is author-extensible
(ruled 2026-08-24) and is not validated on write …" |

No test, doc or changeset quotes either message with the pointer: the
census reads 0 in `.changeset/`, and the anchor sweep finds no test
literal that drops.
9. **`objectstack-ai#3391/objectstack-ai#3546`.** On the two lines that pair them (`managedBy.ts`,
`ObjectGrid.tsx`), both halves are qualified, as batch 6 qualified both
halves of "#13337/#13086". The other bare `objectstack-ai#3546` lines are not in this
batch's lists and are left (**Acceptance notes** 2).

## The literal-anchor sweep (both test-pin classes, ruling `5861900779`)

- **Instrument.** Every string, template and regex literal in all 4073
tracked test and script files (106544 distinct literals), read with the
TypeScript scanner.
- **Candidate filter.** A literal is a candidate if it matches the
diff's removed lines with two lines of context, raw or
comment-flattened: 1983.
- **Test.** Does its occurrence count DROP between `3b469c8ea` and
`c292a6400` in any of the 74 changed files, raw or comment-flattened?
136 do.
- **Every one is generic:** digits, punctuation, single words ("object",
"blocked", "locked"), character classes, and two regexes that read no
changed file: `/objectui#\d+|objectstack#\d+/` in
`registry-inputs-spec-parity`, which asserts over its own ledger's
reasons, and the older spelling of the three submitRedirect tests'
ruling matcher, quoted in their own doc comments (the live
`CITES_ITS_RULING` asserts over their own refusal text). None is a
changed phrase, a dead number or a changed warning.

## Held

**By the serial rule: nothing.** Open PRs were mapped at branch time (9
open) and again after the push, before this PR opened (11 open). The
second mapping came after the push, not before it; the same three files
were shared both times.

Three open PRs share a file with this PR:
- _Both PRs below have merged since this PR opened (objectui#10945 as
`06a96e948`, objectui#10908 as `b45d463a9`). The trial merge with
today's `main` is clean, and both censuses read 0 on it (contract review
`5870922323`), so nothing is owed. The two rows are kept as the record
at the time._
- **objectui#10945, `RecordDetailView.tsx`.** The blob at its merge-base
equals the branch point's. Its hunks are the imports and one block far
below; this PR's one changed line in that file is far from both.
- **objectui#10908, `types/src/zod/index.zod.ts`.** Its one insertion is
in the export list, far below this PR's two changed comment lines.
- **objectui#10278, `plugin-grid/src/ObjectGrid.tsx`.** The file drifted
between its merge-base and the branch point, so this PR's four changed
lines were mapped onto its merge-base by a line alignment: the nearest
of its hunks is more than 150 lines from any of them.

Trial merges with this head (`git merge-tree --write-tree`):
- clean for objectui#10952, objectstack-ai#10950, objectstack-ai#10949, objectstack-ai#10947, objectstack-ai#10945, objectstack-ai#10944,
objectstack-ai#10930, objectstack-ai#10908 and objectstack-ai#10777;
- objectui#10278 conflicts in `ObjectGrid.tsx`, `plugin-grid/README.md`
and `content/docs/plugins/plugin-grid.mdx`, and conflicts in the same
three files against `main` alone;
- objectui#5400 (Version Packages) regenerates and is not a hold.

`.changeset/9954-read-rate-banner.md` is held by this seat's
objectui#10913 dispatch (PR objectui#10949) and is untouched here. It
carries none of this batch's numbers.

## Changesets

- `.changeset/10803-dead-citation-sweep-seventh-batch.md`, EMPTY
frontmatter. It covers the comment-only edits in 17 released packages;
no published behaviour changes through them. It points at the second
file for the runtime text.
- `.changeset/10803-seventh-batch-runtime-strings.md`,
`'@object-ui/app-shell': patch` and `'@object-ui/plugin-detail': patch`:
the two warnings lose their pointer. What renders, and when and how
often each warning fires, are unchanged.

## Proof of prose-only (C4), against `3b469c8ea`

- **Source.** Each of the 48 touched `.ts` / `.tsx` files was parsed at
`3b469c8ea` and at this head with TypeScript 6.0.3's `createSourceFile`,
and re-printed by `createPrinter({ removeComments: true })`.
  - 46 of 48 prints are identical.
- `activityItemType.ts` and `recordActivityFeed.ts` are equal once the
one listed substitution each (**Special cases** 8) is applied to the
base print, each matched once.
  - 0 parse diagnostics.
- Lit controls on the same instrument: editing a string literal moves
the print; re-spacing a comment does not.
- **Changesets.** The frontmatter block of every one of the 24 edited
changesets is byte-identical at `3b469c8ea` and this head (24 of 24,
md5). The overwrite gate below agrees.
- **Scope of the diff:** 74 files, +157 / −115: 24 edited and 2 new
changesets, and 48 non-test source files in 17 released packages. No
test file.

## Gates, on this head `c292a6400`

Each line is the gate's own verdict and exit code, captured by
redirect-then-`$?`.

- `node scripts/check-changeset-presence.mjs`, exit 0: "48 source
file(s) of 17 released package(s) changed, and this change declares 2
changeset(s): .changeset/10803-dead-citation-sweep-seventh-batch.md,
.changeset/10803-seventh-batch-runtime-strings.md."
- `pnpm changeset:check`, exit 0: "All workspace packages are in the
changeset fixed group." / "No changeset declares a `major` bump."
- `node scripts/check-changeset-overwrite.mjs` (report-only), exit 0: "2
changeset(s) added, 24 modified, 0 deleted". `declared at base` equals
`declares now` for each of the 24.
- `pnpm check:changeset-claims` (report-only), exit 0:
- "Every one of those 1 address(es) either names the tree it was read
from, or points at a line this change does not move";
- "Every package declared across those 22 body(ies) is either not
negated …";
- the standing notice "87 pending changeset(s) describe a file this
change touches". Read against the diff: a pending changeset quoting a
replaced pointer would itself carry a dead number and sit in the census,
which reads 0.
- `pnpm check:control-bytes`, exit 0: "check-control-bytes: OK (scanned
9229 tracked text file(s); skipped 85 binary)." A `grep -P` control-byte
self-scan of the 74 files finds none.
- `pnpm check:new-line-citations`, exit 0: "VERDICT
new-cross-file-line-citations: 0 new citation(s), enforcement
report-only -> exit 0".
- `pnpm check:pending-changeset-literals`, exit 0: "No test source names
a pending changeset."
- Also run over the touched comments:
- `pnpm check:spec-symbols`, exit 0: "spec member citations: 1421
sources + 184 documentation pages; nothing cites a key its spec symbol
does not declare.";
  - `pnpm check:installed-pin-claims`, exit 0 ("OK");
- `pnpm check:comment-mask-corpus`, exit 0 (1 disagreeing file, within
the ceiling objectui#7882 holds open);
- `node scripts/check-hand-rolled-comment-mask.mjs`, exit 0 ("OK every
carrier is a DEBT entry, and every DEBT entry still carries one.");
- `pnpm check:handler-key-reads`, exit 0 ("every judged read is a
declared member of it").
- The governed-surface predicate over the 74 paths, exit 0: "NOT
GOVERNED — 74 path(s) checked against 5 governed surface(s); none
matched." Lit control `AGENTS.md`: exit 3.

**Tests and type-check**, through the shared verify lock, on
`c292a6400`. Each is `VERDICT command-exit 0`.
- `scripts/__tests__/`, the whole directory, whose whole-tree scanners
read the touched files and changesets: `Test Files 177 passed | 2
skipped (179)`, `Tests 5332 passed | 2 skipped (5334)`. The two skipped
files are the network-escape fixtures that run only as a child.
- `packages/types/`, `core/`, `react/`, `i18n/`, `providers/`,
`permissions/` and `data-objectstack/`, whole packages, in one run:
`Test Files 704 passed (704)`, `Tests 13170 passed | 13 skipped
(13183)`.
- The eight touched plugin packages (calendar, designer, detail, form,
grid, kanban, list, tree): `Test Files 787 passed | 1 skipped (788)`,
`Tests 7521 passed | 27 skipped (7548)`.
- `packages/components/`: `Test Files 324 passed | 1 skipped (325)`,
`Tests 3148 passed | 24 skipped (3172)`.
- `packages/app-shell/`: `Test Files 854 passed | 1 skipped (855)`,
`Tests 8789 passed | 9 skipped (8798)`.
- Type-check: `turbo run build` of the 28-package dependency closure
(`Tasks: 28 successful, 28 total`), then `pnpm
--workspace-concurrency=2` with the 17 package filters `run type-check`:
17 script echoes, 17 `Done`. A first attempt before the build exited 2
on an unbuilt dependency (`Cannot find module '@object-ui/types'`) and
measured nothing.
- No red leg: the sweep found no anchor to move, so there is no pin
whose old copy should fail.

CI on `c292a6400`: 43 check-runs, 40 success, 3 skipped, 0 failed; `Spec
Main Shape Gate` success.

## Acceptance notes

1. **Dead objectstack numbers written bare: 10 more lines in the same
two classes.** A bare number resolves to this repository, where each of
these is a live, unrelated card, so no `objectstack#` census sees them.
- **Measurement.** The bare-number instrument of PRs objectui#10875 /
objectstack-ai#10892 / objectstack-ai#10914 reads 965 distinct numbers at this head. The 916 between
100 and 25000 were each read once as objectstack issues: 877 answer 200
and 39 answer 404. Reading the sentences of those 39, three mean an
objectstack card or pull request (below); the other 36 cite objectui
cards or objectui pull requests.
- **objectstack-ai#9934**, 7 lines in 7 files:
`.changeset/7980-agent-key-envelope-read.md`, and in app-shell
`index.ts`, `apiErrorEnvelope.ts` (2), `PackageFormDialog.tsx`,
`StudioDesignSurface.tsx` and `packages-io.ts`. All mean the
`userMessage` channel, objectstack `79c46da90`.
- **"PR objectstack-ai#6281"**, 2 lines in `containers.tsx`, beside objectstack#5775.
The landing is objectstack `85ec26d28`.
- **"objectstack PR objectstack-ai#8452"**, 1 line in `useRecordCrudVerdicts.ts`. The
landing is objectstack `27358d517` ("add batch recordIds to
security/explain (objectstack-ai#8326) (objectstack-ai#8452)").
- None of them sits in a sentence this PR edits, so they are outside
this batch's lists and left. Carrier: this card, triage item 3.
2. **The rest of the bare `objectstack-ai#3546` population.** Five more comment lines
write objectstack#3546 as a bare `objectstack-ai#3546` (`RecordDetailView.tsx` 2,
`RelatedRecordActionsBridge.tsx`, `record-details.tsx`,
`fieldWriteGate.ts`), and one writes it as `objectui#3546`
(`plugin-detail`'s `index.tsx`). Each names the server's effective API
operation set on a detail or form surface. It is live-but-wrong, not a
404, like the `objectstack-ai#3391` class this batch closed. Carrier: none.
3. **A stale label in a comment.** The `ObjectCalendar.tsx` sentence
said objectui#8652 is `pm:blocked`; that card reads `pm:on-hold` today.
**Special cases** 1 says how the repaired sentence avoids the label.
4. **Filenames are not citations.**
`.changeset/17147-plugin-disclosure-not-enforced.md` carries one of the
30 numbers in its name; it stays, as in PRs objectui#10707, objectstack-ai#10797,
objectstack-ai#10854, objectstack-ai#10869, objectstack-ai#10875, objectstack-ai#10892 and objectstack-ai#10914.

---
_Generated by [Claude
Code](https://claude.ai/code/session_01DuWo5bdP9SdVebamn99GGk)_

_Tests block completed by the `domain:ui` seat objectstack-ai#1 from the dev report
`5870507620` (the suites that finished after this PR opened), and three
figures corrected after contract review `5870922323` (the objectstack-ai#9933 and
objectstack-ai#6515 quotes, and the Held rows); no code claim moved._

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants